Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a description of how to test a package #72

Merged
merged 2 commits into from
May 3, 2023
Merged

Add a description of how to test a package #72

merged 2 commits into from
May 3, 2023

Conversation

godalming123
Copy link
Contributor

No description provided.

@godalming123 godalming123 mentioned this pull request Apr 28, 2023
Closed
@godalming123
Copy link
Contributor Author

@Elara6331 can you review this

Elara6331
Elara6331 requested changes May 3, 2023
View reviewed changes
Copy link
Member

@Elara6331 Elara6331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I've been a bit busy lately. There are some small changes I'd like you to make. Otherwise, looks good :)

docs/packages/adding-packages.md Outdated Show resolved Hide resolved
@godalming123
Copy link
Contributor Author

godalming123 commented May 3, 2023 •
edited
Loading

Will fix when I get home at 4:40 (GMT time)

@Elara6331
Fix some grammer
1fd0278 
Co-authored-by: Elara Musayelyan <[email protected]>
@godalming123
Copy link
Contributor Author

@Elara6331 all of your suggested me changes have been implemented

Elara6331
Elara6331 approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@Elara6331 Elara6331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, merging now

@Elara6331 Elara6331 merged commit 3a8eecf into lure-sh:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elara6331 Elara6331 Elara6331 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godalming123 @Elara6331